Remove the default Firefox profile. #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That profile was created 7 years ago. I think the idea was to have certs working for WebPageReplay and there is also some CSS fix for SpeedIndex. I think those fixes are long overdue so lets remove them.
|
Hi @gmierz I've been doing cleaning in the Browsertime and I think the setup with the Firefox profile could go away. I'm not sure if you are the right person to ask? |
|
Want to get this in the release going out this weekend. |
|
Hi @soulgalore, sorry I was out on holiday. I agree that this can be removed :) |
|
Np thank you @gmierz :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That profile was created 7 years ago. I think the idea was to have certs working for WebPageReplay and there is also some CSS fix for SpeedIndex. I think those fixes are long overdue so lets remove them.